Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar not reset when marking episodes as played via multi-select #7144

Open
4 tasks done
loucasal opened this issue Apr 27, 2024 · 2 comments · May be fixed by #7168
Open
4 tasks done

Progress bar not reset when marking episodes as played via multi-select #7144

loucasal opened this issue Apr 27, 2024 · 2 comments · May be fixed by #7168
Labels
Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet

Comments

@loucasal
Copy link
Contributor

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same bug report.
  • I have also used the search function for CLOSED issues to see if the problem is already solved and just waiting to be released.
  • I will describe the problem with as much detail as possible.
  • If the bug only to occurs with a certain podcast, I will include the URL of that podcast.

App version

3.4.0-beta2

Where did you get the app from

Google Play

Android version

12

Device model

No response

First occurred

Probably not new, but I've never followed these steps with earlier versions

Steps to reproduce

I discovered this while manually setting episodes as played to work around #7092.

  1. Have at least two episodes with a progress bar visible in your Episodes screen
  2. Mark one as unplayed (if working around Played episodes still display progress upon completion #7092), then mark it as played via the long-press menu: as a result, the progress bar is reset
  3. Select the other episode via the multi-select menu and follow the same steps using the FAB menu

Expected behaviour

  1. The episode is marked as played and its progress bar is reset, just like in step 2

Current behaviour

  1. The episode is marked as played, but its progress bar is not reset

Logs

No response

@loucasal loucasal added the Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet label Apr 27, 2024
@flofriday
Copy link
Contributor

I can reproduce the issue in the simulator. The progress bar also won't disappear if the app is screen is reloaded or even if the app is restarted.

@ByteHamster
Copy link
Member

Currently multi-select and single-select use different code to handle the actions. We should switch everything to using the multi-select code (and make the multi-select code consistent with the single-select code).

@flofriday flofriday linked a pull request May 7, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants