Shownotes links hard to read on dynamic themes

[flofriday]

Checklist

• I have used the search function for OPEN issues to see if someone else has already submitted the same bug report.
• I have also used the search function for CLOSED issues to see if the problem is already solved and just waiting to be released.
• I will describe the problem with as much detail as possible.
• If the bug only to occurs with a certain podcast, I will include the URL of that podcast.

App version

3.3.2f (develop branch)

Where did you get the app from

Other

Android version

14

Device model

Simulator (Pixel 8)

First occurred

Since material you introduction

Steps to reproduce

1. Enable dynamic colors in the preferences
2. Go to any episode's shownotes with links
3. Play a devious version of "where is waldo" and try to find all the links in the show notes 😜

Expected behaviour

The links stand out somehow

Current behaviour

They can barley be distinguished from the other text.

To be fair I don't think this is particularly the fault of Antennapod, it is much more Androids fault cause it really does select accent colors that are quite muted and very close to the primary text color.
However, I think we should still improve their readability.

Logs

No response

Possible solutions

In the screenshot below I show the current situation (left), how it would look like if we switch the links from accentColor to primaryColor (middle) or if we leave the color and just add an underline (right).

Personally, I think both solutions are fine, most other apps currently opt for underlining (Spotify for example). Also for the implementation it is open if we should change that behaviour just for dynamic colors as for the non dynamic themes the accent color is good enough to read.

[flofriday]

Actually, by default the android webview will show an underline for all links but our shownotes-style.css removes them.

[tonytamsf]

Thoughts about changing the CSS @keunes ?

I think @flofriday is referring to this line

AntennaPod/app/src/main/assets/shownotes-style.css

Line 7 in 92ab575

text-decoration: none;

[keunes]

Thanks both!

I was thinking: I prefer visually only the colour change because it's neater, but is really OK to do away with the underline? Seems yes, it's OK:
https://www.nngroup.com/articles/clickable-elements/

It is recommended to make links blue, and to ensure good enough colour contrast. Makes me wonder how this works: If I understand correctly we can specify different things for 'normal' and 'dynamic'. Even with dynamic colour in your second screenshot I believe that the contrast is a bit on the low side. Could we somehow avoid these links from being adapted?

it is open if we should change that behaviour just for dynamic colors as for the non dynamic themes the accent color is good enough to read.

I think the 'normal' colours look fine, yes.

[ByteHamster]

I would keep the accent colors for links. Otherwise there is this different shade of blue that doesn't really fit the others. I would just add the underline