Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: custom Android auto button icons in 'develop' branch are wrong #7131

Closed
4 tasks done
tonytamsf opened this issue Apr 22, 2024 · 8 comments
Closed
4 tasks done
Labels
Functionality: Interacting devices Anything related to Android Auto, smart watches & smart speakers Type: Confirmed bug Bugs confirmed by a lead developer
Milestone

Comments

@tonytamsf
Copy link
Member

tonytamsf commented Apr 22, 2024

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same bug report.
  • I have also used the search function for CLOSED issues to see if the problem is already solved and just waiting to be released.
  • I will describe the problem with as much detail as possible.
  • If the bug only to occurs with a certain podcast, I will include the URL of that podcast.

App version

3.3.2f (c56facd)

Where did you get the app from

Other

Android version

built from c56facd

Device model

Pixel 6A

First occurred

I think it's after this PR was merged #7053

Steps to reproduce

  1. Start Android Auto emulator with device plugged in and with Android Auto debug mode
  2. Download 3 episodes into the Queue
  3. Run AntennaPod Debug
  4. Navigate to an episode on the emulator
  5. Click on the 5 buttons

Script to start Android Auto

cd ~/Library/Android/sdk

./platform-tools/adb forward tcp:5277 tcp:5277
./platform-tools/adb devices
./extras/google/auto/desktop-head-unit

Expected behaviour

The buttons should do what the icons are showing

Current behaviour

The Skip button is map to change speed
There is an AP icon that maps to rewind
The rewind button is map to fastward
There is an ZZZ button mapped to Skip to next

2024-04-22 22:01:40.775 27428-27428 MediaSessionCompat de.danoeh.antennapod.debug D onCustomAction(action.de.danoeh.antennapod.core.service.changePlaybackSpeed)
2024-04-22 22:01:41.840 27428-27428 MediaSessionCompat de.danoeh.antennapod.debug D onCustomAction(action.de.danoeh.antennapod.core.service.rewind)
2024-04-22 22:01:43.966 27428-27428 MediaSessionCompat de.danoeh.antennapod.debug D onCustomAction(action.de.danoeh.antennapod.core.service.fastForward)
2024-04-22 22:01:44.697 27428-27428 MediaSessionCompat de.danoeh.antennapod.debug D onCustomAction(action.de.danoeh.antennapod.core.service.skipToNext)

Logs

2024-04-22 22:01:40.775 27428-27428 MediaSessionCompat      de.danoeh.antennapod.debug           D  onCustomAction(action.de.danoeh.antennapod.core.service.changePlaybackSpeed)
2024-04-22 22:01:41.840 27428-27428 MediaSessionCompat      de.danoeh.antennapod.debug           D  onCustomAction(action.de.danoeh.antennapod.core.service.rewind)
2024-04-22 22:01:43.966 27428-27428 MediaSessionCompat      de.danoeh.antennapod.debug           D  onCustomAction(action.de.danoeh.antennapod.core.service.fastForward)
2024-04-22 22:01:44.697 27428-27428 MediaSessionCompat      de.danoeh.antennapod.debug           D  onCustomAction(action.de.danoeh.antennapod.core.service.skipToNext)

Image

Screenshot 2024-04-22 at 10 04 50 PM
@tonytamsf tonytamsf added the Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet label Apr 22, 2024
@tonytamsf
Copy link
Member Author

From this SHA 2f58b4b360ae9b701efcf709b79f170210c30ee1, the correct display is fine. See image

Screenshot 2024-04-22 at 10 07 49 PM

@tonytamsf tonytamsf changed the title custom Android auto button icons in 'develop' branch are wrong regression: custom Android auto button icons in 'develop' branch are wrong Apr 22, 2024
@keunes keunes added Type: Confirmed bug Bugs confirmed by a lead developer Functionality: Interacting devices Anything related to Android Auto, smart watches & smart speakers and removed Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet labels Apr 22, 2024
@hades
Copy link
Contributor

hades commented Apr 23, 2024

Not sure I see the connection to #7053 but I'll take a look.

@tonytamsf
Copy link
Member Author

Not sure I see the connection to #7053 but I'll take a look.

It could be unrelated to your PR, sorry I jumped to that conclusion so quickly and without doing the work to narrow down the root cause. Your PR does enable us to fix some long standing Android Auto bugs, thanks for that work.

@hades
Copy link
Contributor

hades commented Apr 23, 2024

No worries at all! If you want, you can assign all Android Auto bugs to me; I'm using AntennaPod in my car a lot, and I'm very motivated to fix all the issues.

@kacnje
Copy link

kacnje commented Apr 23, 2024

No worries at all! If you want, you can assign all Android Auto bugs to me; I'm using AntennaPod in my car a lot, and I'm very motivated to fix all the issues.

Nice to hear 😉😁
Did you check https://github.com/AntennaPod/AntennaPod/issues/7104#issue-2243490891?

@tonytamsf
Copy link
Member Author

No worries at all! If you want, you can assign all Android Auto bugs to me; I'm using AntennaPod in my car a lot, and I'm very motivated to fix all the issues.

@hades FYI, here is an existing list of Android Auto bugs. I was working on fixing some of the previous Android Auto bugs because I use AP in my car a lot as well, and now I'm happy to see that you will also be trying to fix them!

Functionality: Interacting devices Anything related to Android Auto, smart watches & smart speakers

@ByteHamster ByteHamster added this to the 3.5.x milestone Apr 24, 2024
@hades
Copy link
Contributor

hades commented Apr 30, 2024

This seems to be caused by resource ID renumbering that happened in c56facd. It seems that Android Auto caches the icons and does not invalidate the cache when the app is reinstalled (perhaps it's keyed by app version?).

Restarting the phone fixes the icon issue, and I would expect this to not occur in production builds. I suggest this issue be closed.

@ByteHamster
Copy link
Member

Closing because of what @hades commented but feel free to re-open if this still happens @tonytamsf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality: Interacting devices Anything related to Android Auto, smart watches & smart speakers Type: Confirmed bug Bugs confirmed by a lead developer
Projects
None yet
Development

No branches or pull requests

5 participants