Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to change app language #7117

Open
4 tasks done
ApostolosKourpadakis opened this issue Apr 19, 2024 · 4 comments
Open
4 tasks done

Option to change app language #7117

ApostolosKourpadakis opened this issue Apr 19, 2024 · 4 comments
Labels
Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed Type: Feature request

Comments

@ApostolosKourpadakis
Copy link

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same feature request.
  • I have also used the search function for CLOSED issues to see if the feature was already implemented and is just waiting to be released, or if the feature was rejected.
  • I will describe the problem with as much detail as possible.
  • This request contains only one single feature, not a list of multiple (related) features.

App version

3.3.2

Where did you get the app from

Google Play

Problem you may be having, or feature you want

So I use the application for about a month now and when I first downloaded I am pretty sure it was by default in English. When I opened again the app after some weeks, it had automatically changed to Greek. So I searched in the settings if there is an option to change languages but I couldn't find one. I think that this could be a great feature because not everyone that lives in a country (e.g. Greece) is familiar with the native language. If this feature already exists please let me know!

Suggested solution

No response

Screenshots / Drawings / Technical details

No response

@ApostolosKourpadakis ApostolosKourpadakis added Needs: Triage The core team still needs to decide if this feature would get accepted Type: Feature request labels Apr 19, 2024
@ByteHamster
Copy link
Member

This was already requested in #113. I think, however, that things have changed since then. Android 13+ supports per-app language settings, which we can enable as follows: https://developer.android.com/guide/topics/resources/app-languages

For someone implementing this, first try the automatic version and see if it contains languages that we don't actually support. If that is the case, create a script to create the language config file from the list of actual AntennaPod languages (i18n/values directory)

not everyone that lives in a country (e.g. Greece) is familiar with the native language.

The language is not based on your location but on what language you select on the Android settings screen.

@ByteHamster ByteHamster added Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed and removed Needs: Triage The core team still needs to decide if this feature would get accepted labels Apr 19, 2024
@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/implement-android-13-per-app-language-setting/2287/2

@tonytamsf
Copy link
Member

If that is the case, create a script to create the language config file from the list of actual AntennaPod languages (i18n/values directory)

@ByteHamster You are suggesting to run the script on the device?

@ByteHamster
Copy link
Member

No, my idea was to have a script that we can run as part of creating a new release. We already have a bunch of scripts there (contributors list, website languages, etc). However, if AGP's automatic detection works well for us, we do not need a script (and should not create one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed Type: Feature request
Projects
None yet
Development

No branches or pull requests

4 participants