Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Talkback announce start & end of episode downloads & feed refreshes #7070

Open
4 tasks done
keunes opened this issue Apr 8, 2024 · 5 comments
Open
4 tasks done
Labels
Area: Accessibility Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed Type: Feature request

Comments

@keunes
Copy link
Member

keunes commented Apr 8, 2024

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same feature request.
  • I have also used the search function for CLOSED issues to see if the feature was already implemented and is just waiting to be released, or if the feature was rejected.
  • I will describe the problem with as much detail as possible.
  • This request contains only one single feature, not a list of multiple (related) features.

App version

3.3

Where did you get the app from

Google Play

Problem you may be having, or feature you want

From the forum

Currently, there is no way for a TalkBack user to know if an episode has been downloaded or not. The same goes for refreshing a podcast

Suggested solution

AP could inform the user via custom TalkBack notifications about the refresh process and episode download.
For example, the custom notification could be something like this “refresh started” “refresh completed” “Downloading episodes” “Episodes downloaded”.

Screenshots / Drawings / Technical details

No response

@keunes keunes added Type: Feature request Needs: Triage The core team still needs to decide if this feature would get accepted Area: Accessibility labels Apr 8, 2024
@ByteHamster
Copy link
Member

It already does that on my device (if notifications are enabled)

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/mark-all-newer-older-episodes-as-played-after-selected-one-talkback-feedback/4236/19

@VoidCrater
Copy link

VoidCrater commented Apr 8, 2024

@ByteHamster

It already does that on my device (if notifications are enabled)

TalkBack does inform the user when the podcast refresh or episode download starts, however, it doesn't inform the user when the refresh process has been completed or when an episode download has finished. Custom notifications is useful in cases where the file being downloaded is large and is taking a long time to complete.
Also, when the phone is set on DND or notifications have been disabled, there is no way for a TalkBack user to know if the podcast refresh or episode download has started or not. That's where implementing these custom TalkBack notifications would be very helpful.

@keunes
Copy link
Member Author

keunes commented Apr 10, 2024

We discusssed this one at the Needs: Decision meeting.

We checked and the 'Downloading' notification category currently actually covers both episode downloads & feed refreshes. We should probably split that up.

TalkBack does inform the user when the podcast refresh or episode download starts

We contemplated if maybe we should not have custom, in-app announcements about the download/feed refresh. Because if we do implement custom announcements for start, you would get it announced twice (once through Android notification and once directly from AntennaPod via Talkback).

However, we decided that both start & end should be implemented as Talkback announcement:

  • affected users (those using Talkback) can disable the Android notification for Downloads category to avoid double notifications
  • there's no difference for visually able users, while it improves the situation for visually impaired and blind folks
  • while it's possible to override Do Not Disturb, this is cumbersome to do and doesn't help when notifications at system level are disabled/silenced

it doesn't inform the user when the refresh process has been completed or when an episode download has finished

Visually, the refresh notification disappears. So from your comment we conclude that Android doesn't announce when notifications disappear (?). This reaffirms the above decision.

@VoidCrater
Copy link

VoidCrater commented Apr 11, 2024

This sounds like a really good proposal to me! :)

@ByteHamster ByteHamster added Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed and removed Needs: Triage The core team still needs to decide if this feature would get accepted labels Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Accessibility Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed Type: Feature request
Projects
None yet
Development

No branches or pull requests

4 participants