Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn podcast setting "Include in auto downloads" simple switch into three-state switch #7064

Open
4 tasks done
newtogithubandihavelotstosay opened this issue Apr 6, 2024 · 2 comments

Comments

@newtogithubandihavelotstosay
Copy link

newtogithubandihavelotstosay commented Apr 6, 2024

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same feature request.
  • I have also used the search function for CLOSED issues to see if the feature was already implemented and is just waiting to be released, or if the feature was rejected.
  • I will describe the problem with as much detail as possible.
  • This request contains only one single feature, not a list of multiple (related) features.

App version

3.3.2

Where did you get the app from

F-Droid

Problem you may be having, or feature you want

Current behavior

Enable Automatic download
All new episodes in your feed gets downloaded
Have to manually uncheck podcasts that you don't want to have automatically downloaded out of the 100s of podcasts you're subscribed to

Suggested solution

ℹ️ Implementation instructions
This request has been discussed further below. If you're interested in implementing this, please see the conclusions relevant for implementation below.
The original post has been edited by the project maintainers to add this link.

Suggested behaviour

Enable Automatic download
Manually check the podcasts that you want to have automatically downloaded instead of unchecking 100s of podcasts that you don't want to have automatically downloaded

Screenshots / Drawings / Technical details

No response

@newtogithubandihavelotstosay newtogithubandihavelotstosay added Needs: Triage The core team still needs to decide if this feature would get accepted Type: Feature request labels Apr 6, 2024
@ByteHamster
Copy link
Member

I agree that it might be a bit unexpected. In case you didn't know yet, you can use multi-select to disable automatic downloads for all subscriptions at once. No need to open the settings screen of every single one of them.

@keunes
Copy link
Member

keunes commented Apr 10, 2024

We discussed at Needs: Decision. A true 'reversal' of the approach is not desired.

However, we would propose as follows:

  • At podcast level, turn simple switch into three-state: Global default, Off, On
    • Default: Global default
  • Global setting stays the same
    • Default: as is (disabled)
  • Remove the 'auto-download' checkbox from the 'Podcast preview' screen where you subscribe. This makes the interface simpler, also ahead of the dropping of this separate preview screen as discussed in Add/play single episode without subscribing to podcast #4710, and the user can simply change their global value and if needed change the setting at podcast level after.

This is difficult to implement, however, as currently the global setting is a master switch - if it's turned off none of the automatic download code is run. In the to-be situation, though, significant changes would be needed to change this so that the code will still be run if global is disabled and local is enabled.

@keunes keunes removed the Needs: Triage The core team still needs to decide if this feature would get accepted label Apr 10, 2024
@keunes keunes changed the title Reverse Automatic Download behaviour Change "Include in auto downloads" from simple switch to three-state switch Apr 10, 2024
@keunes keunes changed the title Change "Include in auto downloads" from simple switch to three-state switch Turn podcast setting "Include in auto downloads" simple switch into three-state switch Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants