You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have used the search function for OPEN issues to see if someone else has already submitted the same feature request.
I have also used the search function for CLOSED issues to see if the feature was already implemented and is just waiting to be released, or if the feature was rejected.
I will describe the problem with as much detail as possible.
This request contains only one single feature, not a list of multiple (related) features.
App version
3.3.2
Where did you get the app from
Google Play
Problem you may be having, or feature you want
To be perfectly honest, I have never been a fan of the way the player icons look. I think the sharp edges are ugly. I want to finally change that.
A new animation will need to be created for the new playback speed icon. (Only if an animation is wanted, otherwise it can just be static.) Alternatively we can just use the original, even though I personally think the new one looks better and is more congruent with material design.
The new play/pause animation looks a little bit strange. I tried my best to make one using vectalign. (I don't have experience creating vector animations, so hand-created is probably out of the question for me.)
Hi @peakvalleytech,
That's great, I personally like it. It needs some getting used to, but I think it does fit with AntennaPod's round logo.
However, if we go ahead, we shouldn't limit it to the player, but apply it across the app. In one of the screenshots, for example, I see a pointy favourite icon that feels a bit out of place. Same for the chapter navigation icons, playback speed + & - buttons, etc. (they feel a bit out of place).
A new animation will need to be created for the new playback speed icon. (Only if an animation is wanted, otherwise it can just be static.
Is the animation not obsolete currently, given that it opens the bottom sheet instead of jumping between speeds? (Related: #6019)
The new play/pause animation looks a little bit strange
It's not the conventional morph, but I must say it doesn't disturb me. It feels a bit like both icons are on different sides of a paper, and the paper is flipped.
More and more apps seem to be using outlined, not filled icons. Not sure if we should really stick to filled ones here. If we change icons, we have to change all of them. Not sure if we should really do that.
More and more apps seem to be using outlined, not filled icons
That's related, but not necessarily blocking the change to rounded icons. I don't see charging to outline icons as needed or required. I would stick with filled tbh (I think an outline play button would make things less clear).
Why would you not stick with filled icons? Just because of what other apps are doing? (I haven't noticed this trend btw. Edit: it does seem to be common to use outline in bottom nav, and use filled for the current active screen.)
If we change icons, we have to change all of them. Not sure if we should really do that.
I agree we need to do all of them. But if @TacoTheDank is willing to take that up, what might be the reason against doing that?
Checklist
App version
3.3.2
Where did you get the app from
Google Play
Problem you may be having, or feature you want
To be perfectly honest, I have never been a fan of the way the player icons look. I think the sharp edges are ugly. I want to finally change that.
Suggested solution
I have decided to replace them with rounder versions from https://fonts.google.com/icons?icon.set=Material+Icons. I also decided to use the Google Material-designed speed icon as well.
Two potential issues still exist:
Relevant branch: https://github.com/TacoTheDank/AntennaPod/tree/playerRoundedDesign
Test APK:
app-play-debug playerRoundedDesign.zip
Screenshots / Drawings / Technical details
playerRoundedDesign screenshots.zip
The text was updated successfully, but these errors were encountered: