Allow shake to reset before and after sleep timer fade-out

[forteller]

Checklist

• I have used the search function for open and closed issues to see if someone else has already submitted the same feature request.
• I will describe the problem with as much detail as possible.
• This request contains only one single feature, not a list of multiple (related) features.

App version

2.5.2

Where did you get the app from

Google Play

Problem you may be having, or feature you want

When I set a sleep timer it is always, and every time because I want to listen to something for that period of time. Having to then first press play on the current podcast episode I have open seems unnecessary. There might be a good reason that setting the timer before starting to play anything gives you a notification about no media playing instead of just starting to play it automatically is a good idea that I just haven't thought of.

But when the sleep timer comes to zero and I still haven't been able to sleep, it is more disrupting to my sleep that I have to close the sleep timer box and press play again. At least in these circumstances it seems the most intuitive and best option is that pressing the set timer button would automatically restart the playback from the current time.

Suggested solution

Either always start playing the current episode when pressing the set timer button, or at least always play after pressing the set timer button after the timer has already timed out and you haven't closed the sleep timer box.

Thank you!

Screenshots / Drawings / Technical details

No response

[ByteHamster]

But when the sleep timer comes to zero and I still haven't been able to sleep, it is more disrupting to my sleep that I have to close the sleep timer box and press play again.

That's what the "shake to reset" feature is for :) When you notice that the volume gets less and you are still awake, just shake your phone. You don't even need to open your eyes.

[forteller]

Sure, but if I miss that short window of time when the volume is decreasing, then that doesn't work. So another option would be to extend the period when the shake feature works til some time after the playback has been paused. It should also work before the volume starts decreasing, btw imo, but that's another issue :)

[keunes]

another option would be to extend the period when the shake feature works til some time after the playback has been paused. It should also work before the volume starts decreasing

The former would be helpful and the latter I believe was discussed before at some point (and I believe was positively received).

I'll apply the enhancement request label.

[ByteHamster]

the latter I believe was discussed before at some point (and I believe was positively received).

Hmm, not really. See #4825. I think capturing shakes all the time will trigger too many false positives and use battery power

[ByteHamster]

Another thing I noticed while thinking about this: shake after the fade out might be a bit hard to implement (even though I like the idea of listening to shakes, like, 15 more seconds after playback end). That needs a foreground service with a persistent notification. We cannot use the player notification for that because users might want to swipe it away. So it probably should be its own service with a notification like "sleep timer expired. Shake to reset" and maybe even buttons for +x minutes.

[keunes]

See #4825

Ah, doh. Should we close this issue to keep the discussion in one place?

[forteller]

This is starting to sound like a lot more work than just having the episode start playing when you press "Set timer"? But I'm no coder, so I don't really know :)

[ByteHamster]

Closing because this is already covered in #4825