Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shake to reset uncheck not respected during fadeout #4824

Closed
3 tasks done
Thom-Merrilin opened this issue Jan 1, 2021 · 2 comments
Closed
3 tasks done

Shake to reset uncheck not respected during fadeout #4824

Thom-Merrilin opened this issue Jan 1, 2021 · 2 comments
Labels
Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet

Comments

@Thom-Merrilin
Copy link
Contributor

Checklist

  • I have used the search function to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.
  • If the bug only to occurs with a certain podcast, I will include the URL of that podcast.

System info

App version: 2.1.1 (I also receive this bug when building from source)

App source: F-Droid

Android version: LineageOS 17.1 (Android 10)

Device model: OnePlus 5T

Bug description

Steps to reproduce:

  1. Begin playing podcast
  2. Open sleep timer dialog
  3. Check "Shake to reset"
  4. Wait until the sleep timer count is below 10 seconds, then uncheck "Shake to reset"
  5. Shake the device

Expected behaviour:

At the end of these steps, "Shake to reset" is unchecked, so the sleep timer should not reset.

Current behaviour:

The sleep timer does reset, despite "Shake to reset" being unchecked.
First occurred: (e.g. about x days/weeks ago)

Environment:

Stacktrace/Logcat:

[if available]
@Thom-Merrilin Thom-Merrilin added the Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet label Jan 1, 2021
@Thom-Merrilin
Copy link
Contributor Author

I have written a fix for this that also implements the feature request for issue #4825, and will create a pull request with this.

Thom-Merrilin added a commit to Thom-Merrilin/AntennaPod that referenced this issue Jan 1, 2021
@Thom-Merrilin
Added spinner to time_dialog to allow the user to opt into permitting…
93fff84 
… shake to reset (sleep timer) at any time during the sleep timer.

Addresses issue (AntennaPod#4824)
Addresses issue (AntennaPod#4825)

Details:
	The spinner defaults to "During fadeout" to preserve the original behaviour. If the user opts into the new behaviour by selecting "Anytime" from the spinner, they can shake the reset the sleep timer at any time during the countdown, rather than only during the fadeout. I think this is especially userful for users who do not use the "vibrate" feature of the sleep timer, as the audio fadeout alone can be quite subtle and easily missed.
	This also fixes an issue with the existing sleep timer behaviour - currently the sleep timer will not respect the user unchecking the "shake to reset" option during the fadeout, as the ShakeListener has already been registered, and the callback does not check if the user has enabled shake to reset.
@Thom-Merrilin Thom-Merrilin mentioned this issue Jan 1, 2021
Closed
@ByteHamster
Copy link
Member

I don't really think this is a problem that we need to keep track of. This is mostly a theoretical thing - a normal user will not wait for the timer to run out, then un-check the "shake" option, and then shake (all within 15 seconds before playback is paused). I don't think fixing this little quirk is worth the additional code complexity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added spinner to time_dialog to allow the user to opt into permitting… Thom-Merrilin/AntennaPod
2 participants
@ByteHamster @Thom-Merrilin