Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated preference? #3063

Closed
jawz101 opened this issue Mar 24, 2019 · 5 comments
Closed

duplicated preference? #3063

jawz101 opened this issue Mar 24, 2019 · 5 comments

Comments

@jawz101
Copy link

jawz101 commented Mar 24, 2019

Settings>network>automatic download>episode cleanup>after finishing

Storage>auto delete when playback completes

@ByteHamster
Copy link
Member

ByteHamster commented Mar 24, 2019

They are a bit different. The one under storage deletes after finishing an episode. The other one only deletes when automatic download runs and needs more space. The auto download cleanup seems to not respect the auto download setting, as discussed in #3058. I agree that having both options is kind of strange, especially since they are located in completely different places

@orionlee
Copy link
Contributor

I agree that having the settings in 2 different sections can be confusing to users.

One possible (slight) improvement is to have links / see also, e.g., in automatic download below episode clean up, shows a link of "See also: Storage: auto delete ", so that users at least be aware of other settings.

@jawz101
Copy link
Author

jawz101 commented Mar 25, 2019

Rather than adding more ui elements I would think they should set the other to true if either is picked.

If I "auto delete after playing" I wouldn't have to prefer a different action when free space is limited. And if I prefer to address free space limits by "deleting after finished", I wouldn't have to "auto delete after playing."

@felagund
Copy link

I think they should rather be merged and enhanced in the fashion suggested here:

#1275

My use case would be to have an episode deleted after it is played (or I mark it as such), but with some delay. Either I marked it played by mistake or I I was listening to several episodes in a queue and want to go back after it is finished. Now when the next episode starts playing, the first episode is deleted. There is a chance I misheard something at the end (or I was busy doing something else) and I want to go back. However, if I do not go back withing a few hours, I probably never will and would love the episode to be deleted. Such behaviour is impossible as of now.

@ByteHamster
Copy link
Member

This is a usability problem, not a functional problem. The usability issues are already tracked in #4795. Closing to keep the discussion in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants