Unclarity of Episode Cleanup

[keunes]

Two questions about wording:
What does this function do exactly: Remove = 'remove from queue' or 'delete media file'?

What does 'if space is needed' imply: episode cleanup will be performed only when episode cache is full (as in number of items in the queue = or > cache setting) [rather than continuously checking if an episode/file should be removed]?

And one about the relation to auto-delete:
These settings seem somewhat overlapping, no? Shouldn't they be merged? I find the settings a bit confusing.

Remark about the location
Why is this placed under the Network section? I would expect it close (just below) 'Auto Delete', or if not there at least some other place than Network - it doesn't really have anything directly to do with network/(wifi/mobile) data use?.

[mfietz]

Two questions about wording:

Removel as in deletion. Why would you ever need space in the queue? ;)

What does 'if space is needed' imply

The auto download algorithm makes a list of files it "wants" to download. Then we check how much space we have left in the cache and how many files we can cleanup.

And one about the relation to auto-delete

Not really. Auto Delete is aggressive, get rid of the file as soon as possible (playback completed).
The cleanup only deletes anything if the space is needed, i.e. it is much more defensive. The later also can delete files that have not been completed.

Remark about the location

Actually, the cleanup setting should probably become part of the automatic download submenu as the cleanup algorithm is only ever executed by it.

[keunes]

Tnx for the info.

I now have this in the wiki:

If an episode isn't in the queue and it isn't marked as a favorite, then it can be deleted if space is needed for new episodes. This happens when the auto download algorithm makes a list of files it "wants" to download. Then AP checks how much space there's left in the cache and how many files need to be cleaned up.

Last question:
How does AP prioritise? I.e. which episodes get deleted first? (based on some smart comparison of space needed and freed up by deletion? based on publication date?)

So, as follow-up:

• I've added extra info to the wiki
• "cleanup setting should probably become part of the automatic download submenu as the cleanup algorithm is only ever executed by it" -> agree, would be nice (like Settings: Moved episode cache size to auto download sub-menu #1548's move) (which is sth I wouldn't be able to do)
• I'll do a PR to improve the setting's explanation (Update Episode Cleanup description #1564)

[domingos86]

From experience it seems like it prioritizes based on publication date, so if you just listened to a really old episode, it'll probably be the next one to be deleted (certainly true in my case, where they're good to go as long as not in the queue). I'd say a more natural behavior would be to prioritize based on the last time they were listened, but this feels like such an irrelevant issue that nobody really cares. Not that it shouldn't be documented, just that it's very unlikely people will be affected by it.

[ByteHamster]

@keunes Would you consider this resolved? I think the new position directly below the cache size helps a lot in understanding the setting.

[keunes]

@keunes Would you consider this resolved? I think the new position directly below the cache size helps a lot in understanding the setting.

Hmm. I certainly think it helps a bit. Though the whole feature (#1275) could use a revamp, making it more extensive but more importantly also easier to understand.

Also, an answer to the prioritisation issue would be helpful - do you know how that currently works?

Lastly, I'm starting to doubt the setting explanation: In the string it says 'episodes that are not in the queue may be cleaned up'. But there's 2 options: 'when not in queue', but also 'after finishing', 'x days after finishing', 'never'. Does this mean that the description is false?

• If 'never' is selected, auto Episode Cleanup is effectively disabled (right?)
• If 'after finishing' is selected, it also deletes an episode that is in the queue (which could be the case if Auto Delete is disabled) (right?)

Would the following be correct? Episodes that aren't favorites and fulfill the chosen requirement, should be eligible for removal if Auto Download needs space for new episodes (though linguistically, 'chosen requirement' doesn't work well with the option 'never')

[ByteHamster]

This is a usability problem, not a functional problem. The usability issues are already tracked in #4795. Closing to keep the discussion in one place.