Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 17.4 nfc popup allows to cancel already failed scanning session #210

Open
Thormeard opened this issue Apr 15, 2024 · 0 comments
Open

Comments

@Thormeard
Copy link

Thormeard commented Apr 15, 2024

Seems like iOS 17.4 introduced slightly updated popup design for the nfc scanning.

Previously if you had an error while scanning - it was printing an error without the cancel button, and popup closes itself after a ~1second. With the 17.4 if you have an error - cancel button (and X in the corner) is still there and can be pressed (popup still closes itself). And what happens is that you have an error, click cancel - and you have an UserCanceled event on top of the error after a few seconds, which cancel next scanning session that is being started (if you pressed restart for example).

How to reproduce:

  • Start scanning session
  • Remove your phone from a passport (or make session throw an error somehow)
  • Press the cancel button when you see an error message
  • UserCanceled is triggered a few seconds after an error (and if new session started in between the error and a cancel - new session getting canceled)

Suggestion:

  • Ignore UserCancel error from previous session when new session is started (if this is possible, not sure yet how errors is being thrown from the nfc session). Maybe something similar with the shouldNotReportNextReaderSessionInvalidationErrorUserCanceled logic. Maybe now there is a flag to hide a cancel button in case of an error?

Also minor visual thing - in the iOS 17.4 DisplayMessage (status of scanning) can only contain 2 lines of text. And custom progress bar (made of 🟢) is separated from the text by empty line which pushes progress bar to line 3 which is not visible. I tried to remove 1 spacer - looks too close to the status text.. I don't know if this is a bug or apple decided that 2 lines of text is enough, but reporting just so that you know about it. I would keep it as it is for a while until we going to be sure that 2 lines is here to stay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant