extract.py: Fails for .ml files

[matthiasgeihs]

First of all: Great project!

I stumbled across a minor bug when reading .ml files with the extract.py script.

NFCPassportReader/scripts/extract.py

Lines 29 to 42 in 84e11ec

	# Identify Type of file - either LDIF or MasterList (CMS)
	if filename.lower().endswith( ".ldif" ):
	# Read and parse LDIF File
	(cns,masterLists) = readAndExtractLDIFFile( filename )
	elif filename.lower().endswith( ".ml" ):
	masterLists = readInMasterListFile( filename )
	print( f"Read in {len(masterLists)} masterlist files" )
	print( f"Read in {cns} CNS" )
	for index, ml in enumerate(masterLists):
	certNr = 1
	print( "-----------------------------------" )
	print(f"Verifying and extracting MasterList {index} - {cns[index]}")

For .ml files, the variable cns is not set, and hence the script fails at line 37.

[AndyQ]

Hi @matthiasgeihs Can you give an example of an ml list that fails? (or a location I can get one from?)

[matthiasgeihs]

If I see it correctly, this fails for all .ml files. Concretely, I was testing with the German CSCA Master List.

[AndyQ]

I've just fixed this - its in main and will be in the next release

[matthiasgeihs]

Feel free to close the issue whenever you feel like it. 🙂