Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2.LaunchTemplateProps#keyName is deprecated since CDK v2.119.0 #314

Open
jgreenbow opened this issue Apr 18, 2024 · 0 comments · May be fixed by #315
Open

ec2.LaunchTemplateProps#keyName is deprecated since CDK v2.119.0 #314

jgreenbow opened this issue Apr 18, 2024 · 0 comments · May be fixed by #315

Comments

@jgreenbow
Copy link
Contributor

jgreenbow commented Apr 18, 2024 •
edited

Whenever a FckNatInstanceProvider is created, the deprecation warning about LaunchTemplateProps#keyName is shown. This is independent of whether keyName is actually used in the creation of the FckNatInstanceProvider.

Commit: aws/aws-cdk@22e6ce8

Warning:

[WARNING] aws-cdk-lib.aws_ec2.LaunchTemplateProps#keyName is deprecated.
  - Use `keyPair` instead - https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2-readme.html#using-an-existing-ec2-key-pair
  This API will be removed in the next major release.
jgreenbow pushed a commit to jgreenbow/cdk-fck-nat that referenced this issue Apr 18, 2024
@jgreenbow-userful
fix: only set keyname if exists (AndrewGuenther#314)
a67d901 
Closes AndrewGuenther#314.
@jgreenbow jgreenbow linked a pull request Apr 18, 2024 that will close this issue
Open
@jgreenbow jgreenbow changed the title KeyName is deprecated since CDK v2.119.0 LaunchTemplateProps#keyName is deprecated since CDK v2.119.0 Apr 18, 2024
@jgreenbow jgreenbow changed the title LaunchTemplateProps#keyName is deprecated since CDK v2.119.0 ec2.LaunchTemplateProps#keyName is deprecated since CDK v2.119.0 Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: keyname deprecated warning jgreenbow/cdk-fck-nat
1 participant
@jgreenbow