Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some bugs #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix some bugs #44

wants to merge 1 commit into from

Conversation

TianZerL
Copy link

@TianZerL TianZerL commented Feb 2, 2022

  • Branch instructions may jump incorrectly and take the wrong cycles, this is because cross function always takes offset paramenter as u8, it should be s8 in branch instructions.
  • PC is incremented twice before being pushed by BRK, fixes BRK wrong PC pushed #38.
  • Sprite overflow flag should be set when there are more than 8 sprites, instead of just 8, see nesdev wiki.

@TianZerL
Bug fixes
e2b9780 
Branch instructions may jump incorrectly and take the wrong cycles
PC is incremented twice before being pushed by BRK
Sprite overflow flag should be set when there are more than 8 sprites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BRK wrong PC pushed
1 participant
@TianZerL