Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous snippet for LaTeX-mode: moderncv-cventry #452

Open
bertulli opened this issue Sep 4, 2022 · 1 comment
Open

Erroneous snippet for LaTeX-mode: moderncv-cventry #452

bertulli opened this issue Sep 4, 2022 · 1 comment

Comments

@bertulli
Copy link

bertulli commented Sep 4, 2022

Hi!
I think the snippet moderncv-cventry is wrong. As you see:

# -*- mode: snippet -*-
# name: moderncv-cventry
# key: cventry
# --
\cventry{${1:year}}{${2:job}}{${3:employer}}{${4:city}}{${5:description}}
$0

It expands into the template \cventry{year}{job}{employer}{city}{description}, thus it provides 5 arguments. However, as you can see from this TeX SE question, it actually needs 6. The manual is a bit unclear, I opened an issue even for that. Can it be fixed upstream? I can make a PR if you like.
Thanks!

@AndreaCrotti
Copy link
Owner

Yeah it would be great if you could open a PR @bertulli, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants