Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining TODO's in the code #570

Open
19 tasks done
simzzz opened this issue Nov 10, 2022 · 0 comments · May be fixed by #572
Open
19 tasks done

Remaining TODO's in the code #570

simzzz opened this issue Nov 10, 2022 · 0 comments · May be fixed by #572
Assignees

Comments

@simzzz
Copy link
Contributor

simzzz commented Nov 10, 2022

Adapter

  • ethereum/client.rs - We return an EwtSigningError when the wallet sign fails in the sign() function even though we do not sign an Ethereum Web Token but an Outpace state_root
  • ethereum/ewt.rs - Determine if it's necessary to replace the error in the base64_decode() function for the Payload struct with our own instead of EwtVerifyError

Ad-view Manager

  • - serve/src/routes.rs - Check if the navigator_language value in the options is correct

  • - helpers.rs - Check if the quotes in the fetch_opts variable are correct
    Done in Adview manager serve ads preview #564

  • - manager.rs - Check what should happen if no validators are found in get_next_adunit() for the campaign
    Checked this while working on Infinity Behaviour + AdView Manager Tests #566 , there should always be a validator

  • - manager.rs - Check if there is a scenario in production where the units_with_price for a campaign can be modified

Config

ganache.toml - Check the POST /validator-message route performance, more than 1 second for timeout is a lot!

Primitives

analytics/query.rs - Make the start field in the Time struct either a timestamp or DateTime string when serializing/deserializing
Mentioned in #493, currently low priority

  • - targeting/input/field.rs - Balances enum should drop PublisherEarnedFromCampaign value
  • - targeting/eval.rs - Check the issue linked above the Function enum
  • - lib.rs - Remove allow(unstable_name_collisions) once num::Integer::div_floor() is fixed
  • - unified_num.rs - Check math and write tests for the mod_floor(), gcd(), lcm(), divides(), is_multiple_of(), and div_rem()` functions
    .divides() is deprecated, should we keep it implemented?
  • - cargo.toml - Change ChannelId Serialize implementation in order to remove serde-hex
    How should we serialize it instead?

Sentry

  • - db/analytics.rs - throw a few more analytics in specific DateHours w/ unique Query and check if it filters the analytics correctly in the test_get_analytics_in_december() test
  • - db/campaign.rs - Check and update the statement in fetch_campaign()

#571
Needs more research, exporting to a separate issue

db.rs - Fix error mapping in the create() function of the Manager

Validator Worker

  • - error.rs - Add channel, validatorId etc. for the ChannelNotIntendedForUs Error variant in the enum
    follower.rs - Check if we should use the health value when displaying InvalidNewState
  • - follower.rs - Context for All spender sum Error when overflow occurs in the follower tick
    follower.rs - Should we show the Payout Mismatch between Spent & Earned in on_new_state()
  • - follower.rs - Add context for proposed_balances.check() overflow error
  • - follower.rs - Add context for Transition error
  • - follower.rs - Add context for error in Spenders and Earners transition
  • - lib.rs - Double check get_state_root_hash_returns_correct_hash test
    How should the encoded value be checked?
@simzzz simzzz self-assigned this Nov 10, 2022
@simzzz simzzz linked a pull request Nov 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant