Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP#61: AdEx V5: adview-manager: AIP#31 Targeting changes #322

Open
13 tasks done
elpiel opened this issue Jul 16, 2020 · 0 comments
Open
13 tasks done

AIP#61: AdEx V5: adview-manager: AIP#31 Targeting changes #322

elpiel opened this issue Jul 16, 2020 · 0 comments
Assignees
Milestone

Comments

@elpiel
Copy link
Member

elpiel commented Jul 16, 2020

Part of #296

Required for #312

TODOs:

AIP#31 Targeting changes

AIP#61 V5

  • Use a list validators from which we will query for /units-for-slot
    • Add a warning that this list has priority, first listed has priority over other validators
    • Include the URLs and maybe even the address of the validator?!
  • If a campaign exist in a previous validator, skip any other occurrences of this Campaign
    This has the consequence that the first time a campaign is returned by a validator, it's price (UnitsWithPrice) will be taken into account and all other results from subsequent calls to different validators will be ignored.
  • Take the first validator's /units-for-slot result (fallback ad unit, targeting_input_base, accepted_referrers) and use it in the manager at get_next_ad_unit
elpiel added a commit that referenced this issue Aug 21, 2020
@elpiel elpiel modified the milestone: sentry-v0.2.0 Jan 5, 2021
@elpiel elpiel added this to the sentry-v0.2.0 milestone Sep 2, 2022
@elpiel elpiel changed the title adview-manager: AIP#31 Targeting changes AIP#61: AdEx V5: adview-manager: AIP#31 Targeting changes Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants