State root & Signature as u8
instead of Strings
#214
Labels
Projects
Milestone
u8
instead of Strings
#214
Currently for some of the states where we use
state root
andsignatures
(e.g.ApproveState
,NewState
) we use Strings.Those strings however are hex encoded strings ( without
0x
prefix ).It would help and remove the confusion or need to search and figure out what it was (hex encoded or prefixed or not and etc.) by using
u8
instead and leaving the hex encoding and prefix/no-prefix to the underlying structs (the states) serialization/deserialization.This can be applied to the adapters as well, even for the DummyAdapter's
sign
/verify
, because it usesString
s andString
s can be created from theu8
, unifying the implementations and requirements of the AdaptersNOTE: In order for this to work though, we have to alter the DummyAdapter in a way that will actually return not a string signature
Dummy adapter signature for {state_root} by {validator_id}
, but a valid Hex string instead.The text was updated successfully, but these errors were encountered: