Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Why empty settings is omitted as nil #1351

Open
cangyin opened this issue Feb 22, 2024 · 0 comments
Open

[QUESTION] Why empty settings is omitted as nil #1351

cangyin opened this issue Feb 22, 2024 · 0 comments

Comments

@cangyin
Copy link

cangyin commented Feb 22, 2024

Hello team! I am customizing clickhouse-operator, where there is a need to generate interserver_http_host setting for each host, but the host.Settings field is nil by default, as seen here:

func (n *Normalizer) normalizeConfigurationSettings(settings *api.Settings) *api.Settings {
if settings == nil {
//settings = api.NewSettings()
return nil
}

in commit d372baf

Though I can simply un-comment it, but I am a afraid of breaking some other logic behind the commit. So why empty settings are omitted as nil here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant