-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceMonitor also selects Clickhouse Nodes #1350
Comments
how exactly do you install your did you use values.yaml something like that? serviceMonitor:
enabled: true
additionalResources:
- |
apiVersion: clickhouse.altinity.com/v1
kind: ClickHouseInstallation
metatada:
...
spec:
... |
Yes i pass it via additionalResources. |
In Why do you ensure your clickhouse-server related pods contains the same labels which present in |
I do not pass any additional Labels i think the labels are passed via helm by default but i am not 100% Sure. So since the ClickhouseInstalltion is part of the Clickhouse-Operator the labels are passed automatically. So i think when i is suggested to pass Clickhouse Installtion via .additionalResources the Clickhouse Metrics Service should have another Selector than only the helm default labels? https://github.com/Altinity/clickhouse-operator/blob/master/deploy/helm/templates/_helpers.tpl#L49 We could include an existing label like: clickhouse.altinity.com/chop=0.23.2 which is unique for the clickhouse-operator pod or implement an completly new label which not relys on the helm defaults. |
Hey,
i noticed when i use the ServiceMonitor in the HelmChart also the clickhouse nodes are selected. So Prometheus tries to scrape them on Port 8888 and Port 9999 which leads to an connection refused.
As far as i understand it is not intentend to scrape the Clickhouse Nodes directly but the clickhouse-operator which provides the metrics. My dashboard is already filled with the correct metrics but i get TargetDown Alerts which i want to fix.
I think it is because the Clickhouse Nodes is:
i think the issue is that the Operator and the Clickhouse Services both have the same labels and therefore get picked up by the ServiceMonitor.
The text was updated successfully, but these errors were encountered: