Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo-cd - Upgrading Helm Chart Loops #1299

Open
tman5 opened this issue Jan 4, 2024 · 7 comments
Open

Argo-cd - Upgrading Helm Chart Loops #1299

tman5 opened this issue Jan 4, 2024 · 7 comments

Comments

@tman5
Copy link

tman5 commented Jan 4, 2024

We're using argo-cd with the helm chart to deploy the operator. The problem is upgrading from 0.21.2 - > 0.22.2 argo-cd is looping over the CRD resources. It will show synced, but then not synced. Below is the screenshot of a sample of what it sees as out of sync. It's like it will change it, but then something else changes it back? At first I thought it was labels but the fields involved are not labels in the CRD

image

@Slach
Copy link
Collaborator

Slach commented Jan 4, 2024

You should install CRD separatelly, 0.22.2

helm actually have strange policy about CRD resources

@tman5
Copy link
Author

tman5 commented Jan 4, 2024

Understood, but we have many other operators with custom CRDs we deploy with argo without issue.

@Elyytscha
Copy link

Elyytscha commented Feb 13, 2024

Understood, but we have many other operators with custom CRDs we deploy with argo without issue.

if you use olm with argocd you are fine, if you use argocd with helm for operators you will for sure run into issues with crd's at sometime

well with helm, due to argocd utilizing helm just as template mechanism and not to deploy the manifests, you could be good and argocd could be able to handle crd updates through that.

@tman5
Copy link
Author

tman5 commented Feb 19, 2024

We are using kustomize helm charts. Which technically doesn't deploy a chart but just outputs the manifests - and it still has issues

---
kind: Kustomization
apiVersion: kustomize.config.k8s.io/v1beta1

helmCharts:
  - name: altinity-clickhouse-operator
    releaseName: clickhouse-operator
    namespace: cllickhouse-operator
    repo: https://docs.altinity.com/clickhouse-operator/
    includeCRDs: true

@Slach
Copy link
Collaborator

Slach commented Feb 20, 2024

@tman5 is this not clear what actually do helmCharts with includeCRDs:true in kustomize
looks like nothing useful and you just have non updated CRDs, because this is a HELM architecture problem

@tman5
Copy link
Author

tman5 commented Feb 20, 2024

So if we were to switch to move away from helm charts and just install the straight manifests, I have a question about our existing clickhouse clusters: if the operator pod goes away while we re-provision, will it also delete the clickhouse clusters with it?

@Slach
Copy link
Collaborator

Slach commented Feb 20, 2024

it depends how exactly your kind: ClickHouseInstallation was deployed
if you are use values.yaml which contains additionalResources
then it deleted with on the helm side during uninstall release
in other case it should delete operator deployment wihtout deleting CRDs and ClickHouseInstallations (chi)

better will check it on staging before apply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants