Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric DiskDataBytes can be incorrect due to inactive parts & hardlinks #1295

Open
filimonov opened this issue Dec 22, 2023 · 0 comments
Open

Comments

@filimonov
Copy link
Member

After mutation (especially noop mutation) the whole dataset becomes inactive, and hardlink-copy of that becomes active.

We count both active & inactive in one single metric

toString(sum(bytes_on_disk)) AS metric_DiskDataBytes,

and that may look like the table consumes twice the disk space.

I would count activeparts disk space and inactive parts disk space separately.

Also that metric does not account temp files & detached parts and non-mergetree data etc (so the name is not the best).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant