Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CudaExec policy undefined when building with CUDA but w/o RAJA #1242

Open
szellmann opened this issue Jan 4, 2024 · 1 comment
Open

CudaExec policy undefined when building with CUDA but w/o RAJA #1242

szellmann opened this issue Jan 4, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@szellmann
Copy link
Contributor

I think here: here and here additional checks are required for if ASCENT_RAJA_ENABLED is defined. CudaExec is only defined if ASCENT_RAJA_ENABLED is defined. I'd submit a PR, but I'm not sure if, conversely, the bug is that CudaExec should be defined in either case (with or without RAJA). Adding additional checks there gets me passed this issue though. Without them, files including that header won't compile.

@cyrush
Copy link
Member

cyrush commented Jan 8, 2024

@szellmann thanks for reporting this -- the CudaExec policy does require RAJA.

There are are a few more places that need better guards, I will take a pass and try to remedy all of these.

@cyrush cyrush self-assigned this Jan 8, 2024
@cyrush cyrush added the bug label Jan 8, 2024
@cyrush cyrush added this to the 0.9.3 milestone Jan 8, 2024
@cyrush cyrush modified the milestones: 0.9.3, 0.10.0, 0.9.4 May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants