Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Contract Address QR code function #3306

Open
tab00 opened this issue Sep 19, 2023 · 2 comments
Open

Remove Contract Address QR code function #3306

tab00 opened this issue Sep 19, 2023 · 2 comments

Comments

@tab00
Copy link

tab00 commented Sep 19, 2023

I found that the token address of a token can be found in the "My Wallet Address" screen by clicking on the Ethereum logo on the top right.

Making it possible to show a QR code of the contract address is a bad idea because then someone could scan and send tokens to the contract, instead of the intended recipient. The Ethereum logo could be accidentally pressed. Such tokens can then end up being stuck in there forever as usually token contracts aren't programmed with a custom function for withdrawing tokens.

Usually there's no reason to be sending tokens into a token contract.

@JamesSmartCell
Copy link
Member

Yep ok. This is actually in here for development purposes. Now that we can access it from the token info itself this can be removed.

@JamesSmartCell
Copy link
Member

There's currently no way to access that option, it's been deprecated, but that code should be removed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants