Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Stores - Additional things #529

Open
Dockter opened this issue Feb 23, 2019 · 4 comments
Open

[Feature] Stores - Additional things #529

Dockter opened this issue Feb 23, 2019 · 4 comments
Assignees

Comments

@Dockter
Copy link
Member

Dockter commented Feb 23, 2019

Below are a list of feature requests for Stores.

  1. Ability to change order of items in the shop. Currently the only way is to add/remove items to change the lists order.

  2. Ability to sort the store based on alphabetical and prices.

  3. Player stores?

    • Server gets a 10% cut of sales?
  4. Have stores collect money into, come out of a specified Reserve account?

  5. Have management GUI only allow to open in Admin mode. If normal command is used (npc), then open non-admin gui.

@Grinch
Copy link
Member

Grinch commented Feb 23, 2019

1.) This is something I could implement fairly easily but we would have to add a new column to the database for sortId.
2.) Same as above, easy to implement. Options for sorting would be: Default (sorted by admin sorting), A-Z, Z-A, Price (Low to High), and Price (High to Low)
3.) This won't come anytime soon.
4.) This relies on Reserve being implemented however we can add support for stores to collect to an account specified but we need to ensure we aren't reliant on Reserve as not everyone will have this.

@Zidane
Copy link
Member

Zidane commented Feb 23, 2019

4 simply relies on specifying the UUID/Name of the account to pull from. Doesn't matter who is the econ provider that provides it (Be it Reserve, EconLite, etc).

Better question is wanting to make a Store have a Sponge Account backing.

@Dockter Dockter changed the title Store - Feature Request [Feature] Store - Additional things Feb 25, 2019
@Grinch Grinch self-assigned this Apr 8, 2020
@Grinch
Copy link
Member

Grinch commented Apr 21, 2020

1.) Did we still want to do a sort ID or leave it as it currently is?
2.) This has been implemented.
3.) This is still something that needs to be done, likely implemented if/when we split Stores from Almura's codebase.

5.) Assuming this is still desired, we could add a flag to the command to specify user-only.

@Grinch Grinch changed the title [Feature] Store - Additional things [Feature] Stores - Additional things Apr 21, 2020
@Dockter
Copy link
Member Author

Dockter commented Apr 21, 2020

  1. What you implemented is good.
  2. Thank you!
  3. would be ideal.
  4. Reserve... whats that again?
  5. Ideally yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants