Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"TwoSubfieldLinearCell" saves the dominant_filter amplitude for nondominant_filter unit #337

Open
CloudyDory opened this issue Nov 2, 2023 · 0 comments

Comments

@CloudyDory
Copy link

In line 57-60 of bmtk/simulator/filternet/lgnmodel/cellmodel.py, the dominant_unit and nondominant_unit are created as:

self.dominant_unit = LNUnit(self.dominant_filter, ScalarTransferFunction('s'),
                                    amplitude=self.dominant_filter.amplitude)
self.nondominant_unit = LNUnit(self.nondominant_filter, ScalarTransferFunction('s'),
                               amplitude=self.dominant_filter.amplitude)

This looks strange to me, as the nondominant_unit should save the amplitude as self.nondominant_filter.amplitude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant