New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cpu #22

Open

edumotya wants to merge 1 commit into Algolzw:main from edumotya:fix/cpu

edumotya commented Jan 11, 2024

Fix #21 by simply eliminating the explicit conversion of zero_modules to cuda.

As far as I see create_model will take care of moving everything to cuda

daclip-uir/da-clip/src/open_clip/factory.py

Line 219 in a4e6720

model.to(device=device)


          rm explicit cuda

2866ff1

LukaGiorgadze commented Jan 23, 2024

Thank you, tiny but helpful PR.
Did you test on cpu?

Author

edumotya commented Jan 25, 2024

Sure! it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment