Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADW Asset Load Order #2559

Open
binduwavell opened this issue Jun 22, 2022 · 0 comments
Open

ADW Asset Load Order #2559

binduwavell opened this issue Jun 22, 2022 · 0 comments

Comments

@binduwavell
Copy link
Contributor

In ADW 2.8 and 2.9 (only versions reviewed) ./angular.json includes asset copying rules at projects/content-ee/targets/build/options/assets.

The following "rule":

              {
                "input": "apps/content-ce/app/src/assets",
                "output": "/assets",
                "glob": "**/*"
              },

Occurs before this "rule":

              {
                "input": "node_modules/@alfresco/adf-core/bundles/assets",
                "output": "/assets",
                "glob": "**/*"
              },

As such, apps/content-ce/app/src/assets/images/alfresco-logo.svg is not deployed, instead node_modules/@alfresco/adf-content-services/bundles/assets/alfresco-logo.svg is included in the final build. The two files appear to be the same. Why have the file under apps/content-ce/... if it's never actually used? I think it suggests that devs assumed like me that content-ce would take precedence over assets loaded from adf-core.

We are able to work around this by adding an assets "rule" at the end of the list so our extension actually provides the final file.

I'm creating the issue because I think (and it appears content-ce devs too) that content-ce assets should take precedence over adf-core assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant