Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alfresco Office Services AOS use hardcoded authentication url for oAuth2/openid, incompatibility with other providers #2557

Open
loftux opened this issue Apr 2, 2024 · 0 comments

Comments

@loftux
Copy link

loftux commented Apr 2, 2024

Filing this here, as there is no other public tracker for AOS

The class org.alfresco.module.aosmodule.auth.service.AosAuthenticationUriService use a hardcoded AuthServer url when enabling oAuth2.

This is not compatible with all authentication providers. Better would be if it used the url returned by ``.well-known/openid-configuration`, this should return the correct url, and is what the repository uses. At leas make the url configurable.

Code from decompiled class that is hardcoded.

public String getIdpLoginURI(IdentityServiceConfig identityServiceConfig) {

  PropertyCheck.mandatory(this, "identityServiceConfig", identityServiceConfig);

  return identityServiceConfig.getAuthServerUrl() + "/protocol/openid-connect/auth" + "?client_id=" + identityServiceConfig.getResource() + "&redirect_uri=" + this.getAuthenticateResponseURI() + "&response_type=code" + "&scope=openid";

}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant