Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting fileplans runs into caching issue due to security interceptor #2439

Open
swagnerfaw opened this issue Feb 8, 2024 · 1 comment
Open

Comments

@swagnerfaw
Copy link
Contributor

When RM is enabled and there is a basic RM site, this caching issue occurs, which can lead to unnecessary DB calls.
Every time FilePlanServiceImpl Set<NodeRef> getFilePlans(final StoreRef storeRef) gets called, it is intercepted, and the resulting set gets cleared, when the user does not have read permissions.
The issue occurs when the cached value is returned, because it does not return a copy of the set in the cache, but the set itself. So the GLOBAL shared set inside the cache gets emptied every time it's returned from cache.

@swagnerfaw
Copy link
Contributor Author

See PR #2440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant