Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update merged report UMAP sizing #641

Open
sjspielman opened this issue Jan 2, 2024 · 2 comments
Open

Update merged report UMAP sizing #641

sjspielman opened this issue Jan 2, 2024 · 2 comments
Labels
QC Relevant to the HTML QC report made available to users

Comments

@sjspielman
Copy link
Member

In #636, we are adding merged UMAPs. Once we run some of the larger projects through, we'll want to revisit how we handle overall plot sizing. I've left some TODOs in the code for where we'll probably need to tweak some things.

From the #636 opening comment:

I took a first stab at some kind of sizing for the overall faceted plot, but we'll definitely want to look at all of them to choose the right calculations. If this seems not unreasonable as a first attempt, maybe let's leave it for now and figure it out later.

@sjspielman
Copy link
Member Author

These TODO lines are the ones we'll need to revisit:

# Determine faceting layout based on n_libraries
# TODO: This needs to be revisited when we run the merged objects through
facet_ncol <- dplyr::case_when(
n_libraries <= 20 ~ 4,
n_libraries <= 50 ~ 6,
n_libraries <= 80 ~ 8,
.default = 10
)
# TODO: For now, 3 inches per UMAP row
umap_height <- ceiling(n_libraries / facet_ncol) * 3

@sjspielman sjspielman added the QC Relevant to the HTML QC report made available to users label Jan 16, 2024
@allyhawkins
Copy link
Member

allyhawkins commented Apr 12, 2024

Just noting that after looking at all the reports, everything seems to look good until you get up to 10 columns. The problem isn't the UMAP itself, it's the font size for the facets that need to be adjusted if you are using 10 columns.
Screenshot 2024-04-12 at 11 10 40 AM

This doesn't need to be fixed until we are able to produce a merged object with > 80 samples which is not the case yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QC Relevant to the HTML QC report made available to users
Projects
None yet
Development

No branches or pull requests

2 participants