Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize different types of submitter unknown labels #558

Open
sjspielman opened this issue Nov 13, 2023 · 0 comments
Open

Harmonize different types of submitter unknown labels #558

sjspielman opened this issue Nov 13, 2023 · 0 comments
Labels
QC Relevant to the HTML QC report made available to users

Comments

@sjspielman
Copy link
Member

Originally posted by @jashapiro in #553 (comment):

We're finally all debugged and running through with a test file of submitter cell types, which had all of na, NA, and Unknown labels added in for testing.

Just to clarify, in this case, the original file does not actually have all three types? The reason I ask is because I would probably be okay with normalizing "na" and "NA" (and "n/a" and <N/A>) but if this isn't something we are seeing in real data (yet), I would push that off for a while.


Down the line, we may wish to harmonize submitter labels in the QC report if/when we encounter a situation when there are multiple types of "unknown" labels. This does not need to be part of the 0.7.0 planned cell typing release (#544)

@sjspielman sjspielman added the QC Relevant to the HTML QC report made available to users label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QC Relevant to the HTML QC report made available to users
Projects
None yet
Development

No branches or pull requests

1 participant