Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include parameter for specifying integration order in integration workflow #275

Open
allyhawkins opened this issue Feb 13, 2023 · 1 comment

Comments

@allyhawkins
Copy link
Member

Based on #274 (review), we should add a parameter to the integration workflow to dictate the order to use for integrating libraries: based on the input order, random, or auto using auto.merge. I believe this would only be used for fastMNN integration and would not apply to harmony.

@jashapiro
Copy link
Member

We might want to test in harmony to see if the order of input matters. An "auto" option is not available there, but if we are going to include "random" we could pretty easily do that for harmony too. The only caveat there (which maybe isn't small) is that while fastMNN will preserve input order in output for samples no matter what is given to merge.order and/or auto.merge, actually reordering the samples will change the order for the output and would therefore require resorting after integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants