Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all the implementation classes #105

Open
AlexMathew opened this issue Apr 19, 2018 · 0 comments
Open

Refactor all the implementation classes #105

AlexMathew opened this issue Apr 19, 2018 · 0 comments
Assignees
@AlexMathew
Labels
codeclimate enhancement
Projects
REFACTOR EVERYTHING!

Comments

@AlexMathew
Copy link
Owner

2015 me wrote horrible OO code.

Actually properly use inheritance in the classes. Why is this needed?

  • Helps get rid of a major load of code duplication
  • Forces to break functions down - so decreasing the cognitive complexity of the implementation functions.
@AlexMathew AlexMathew self-assigned this Apr 19, 2018
@AlexMathew AlexMathew mentioned this issue Apr 20, 2018
Merged
@AlexMathew AlexMathew added this to To do in REFACTOR EVERYTHING! via automation Apr 20, 2018
@AlexMathew AlexMathew moved this from To do to In progress in REFACTOR EVERYTHING! Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexMathew AlexMathew

Labels
codeclimate enhancement
Projects
REFACTOR EVERYTHING!
  
In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexMathew