From e8da736c0b02d9736809352c2915ec44ce62fd77 Mon Sep 17 00:00:00 2001 From: Haruka Date: Tue, 5 Mar 2024 02:53:45 +0900 Subject: [PATCH] Skip seen transactions and solutions instead of bailing --- node/router/src/inbound.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/node/router/src/inbound.rs b/node/router/src/inbound.rs index 1b0cf0da22..e47cf39665 100644 --- a/node/router/src/inbound.rs +++ b/node/router/src/inbound.rs @@ -207,7 +207,8 @@ pub trait Inbound: Reading + Outbound { let seen_before = self.router().cache.insert_inbound_solution(peer_ip, message.solution_id).is_some(); // Determine whether to propagate the solution. if seen_before { - bail!("Skipping 'UnconfirmedSolution' from '{peer_ip}'") + trace!("Skipping 'UnconfirmedSolution' from '{peer_ip}'"); + return Ok(()); } // Perform the deferred non-blocking deserialization of the solution. let solution = match message.solution.deserialize().await { @@ -232,7 +233,8 @@ pub trait Inbound: Reading + Outbound { self.router().cache.insert_inbound_transaction(peer_ip, message.transaction_id).is_some(); // Determine whether to propagate the transaction. if seen_before { - bail!("Skipping 'UnconfirmedTransaction' from '{peer_ip}'") + trace!("Skipping 'UnconfirmedTransaction' from '{peer_ip}'"); + return Ok(()); } // Perform the deferred non-blocking deserialization of the transaction. let transaction = match message.transaction.deserialize().await {