From 910784ed8d6952d8736010fbde086d13a4a294eb Mon Sep 17 00:00:00 2001
From: Haruka <mrx@hcc.im>
Date: Tue, 5 Mar 2024 02:53:45 +0900
Subject: [PATCH] Skip seen transactions and solutions instead of bailing

---
 node/router/src/inbound.rs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/node/router/src/inbound.rs b/node/router/src/inbound.rs
index 3f29d28257..f57933fbea 100644
--- a/node/router/src/inbound.rs
+++ b/node/router/src/inbound.rs
@@ -210,7 +210,8 @@ pub trait Inbound<N: Network>: Reading + Outbound<N> {
                 let seen_before = self.router().cache.insert_inbound_solution(peer_ip, message.solution_id).is_some();
                 // Determine whether to propagate the solution.
                 if seen_before {
-                    bail!("Skipping 'UnconfirmedSolution' from '{peer_ip}'")
+                    trace!("Skipping 'UnconfirmedSolution' from '{peer_ip}'");
+                    return Ok(());
                 }
                 // Perform the deferred non-blocking deserialization of the solution.
                 let solution = match message.solution.deserialize().await {
@@ -235,7 +236,8 @@ pub trait Inbound<N: Network>: Reading + Outbound<N> {
                     self.router().cache.insert_inbound_transaction(peer_ip, message.transaction_id).is_some();
                 // Determine whether to propagate the transaction.
                 if seen_before {
-                    bail!("Skipping 'UnconfirmedTransaction' from '{peer_ip}'")
+                    trace!("Skipping 'UnconfirmedTransaction' from '{peer_ip}'");
+                    return Ok(());
                 }
                 // Perform the deferred non-blocking deserialization of the transaction.
                 let transaction = match message.transaction.deserialize().await {