Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Timestamp GC #3187

Merged
merged 1 commit into from Mar 25, 2024
Merged

[Cleanup] Timestamp GC #3187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions node/bft/src/helpers/timestamp.rs
View file
Open in desktop
Expand Up @@ -28,11 +28,6 @@ pub fn check_timestamp_for_liveness(timestamp: i64) -> Result<()> {
if timestamp > (now() + MAX_TIMESTAMP_DELTA_IN_SECS) {
bail!("Timestamp {timestamp} is too far in the future")
}
// TODO (howardwu): Ensure the timestamp is after the previous timestamp. (Needs Bullshark committee)
// // Ensure the timestamp is after the previous timestamp.
// if timestamp <= committee.previous_timestamp() {
// bail!("Timestamp {timestamp} for the proposed batch must be after the previous round timestamp")
// }
Ok(())
}

Expand Down