[Test] gateway e2e responder handshake testing (no noise) #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklaslong
changed the title
niklaslong
force-pushed
the
tests/gateway-no-noise
branch
from
af2fa51
to
5866f40
Compare
|
Note, we may need to increase the timeouts slightly if the tests end up being flaky on CI. |
niklaslong
force-pushed
the
tests/gateway-no-noise
branch
3 times, most recently
from
aa74149
to
1483b3a
Compare
niklaslong
force-pushed
the
tests/gateway-no-noise
branch
2 times, most recently
from
160ee38
to
a8a971d
Compare
|
Rebased. Note the bft integration tests will fail as they currently do on |
niklaslong
force-pushed
the
tests/gateway-no-noise
branch
from
a8a971d
to
5cce3f0
Compare
|
Rebased on top of #3174 to fix the build, the last 6 commits are new. |
niklaslong
force-pushed
the
tests/gateway-no-noise
branch
3 times, most recently
from
ef1fded
to
fd9a32b
Compare
niklaslong
force-pushed
the
tests/gateway-no-noise
branch
from
fd9a32b
to
1ad425a
Compare
joske
reviewed
Mar 27, 2024
niklaslong
force-pushed
the
tests/gateway-no-noise
branch
from
1ad425a
to
4f998a5
Compare
niklaslong
force-pushed
the
tests/gateway-no-noise
branch
2 times, most recently
from
8d57dd3
to
e01a329
Compare
Includes responder side: - timeouts - invalid challenge request/response - unexpected disconnects
Also moves the test helpers from components into utils.
howardwu
changed the title
howardwu
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A replacement PR for #2660 without the noise changes. Increases gateway handshake test coverage to various cases including:
The happy path is exercised in all our e2e tests already so this changeset focusses on the failure cases.
Drafted for now (I may add a few more cases) but comments already welcome!