Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimized key in form & anonymous functions Refactoring #835

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

momodaka
Copy link
Contributor

@momodaka momodaka commented Dec 30, 2023

Motivation

  • Optimized InputForm.jsx:

Removed unused keys in createFormField to improve code cleanliness.
Avoided using index as keys in FormGenerator , stable keys in list ensure efficient updates and prevent rendering issues.

  • Anonymous functions Refactoring

Replaced anonymous functions in several components with useMemo to optimize performance and better readability.
The naming, such as signatureString is more suitable for a variable rather than a function.

Test Plan

no unit test for website currently, manual regression testing is required.

Related PRs

N/A

@momodaka momodaka changed the title R refactor: optimized key in form & anonymous functions Refactoring Dec 30, 2023
@momodaka
Copy link
Contributor Author

Hi @onetrickwolf and the team! I trust everything is running smoothly.
I observed that my pull request #835 hasn't had any recent activity. If there's anything I can do to assist or speed up the review process, please let me know. I'm enthusiastic about contributing and appreciate your time. Thanks!

@onetrickwolf onetrickwolf self-requested a review January 21, 2024 05:16
@onetrickwolf onetrickwolf self-assigned this Jan 21, 2024
@onetrickwolf
Copy link
Collaborator

@momodaka you are good on your end my fault for not reviewing sooner! We are just currently in the middle of a stress test offsite: https://twitter.com/AleoHQ/status/1744816856978915557

I'll see if I can get to it sooner but worst case I'll be really going through these once we get back on the 29th sorry for delay and thanks for the contribution!

Working on getting more maintainers soon as well so hopefully handle these faster soon!

@momodaka
Copy link
Contributor Author

@onetrickwolf Thanks for the update! Best of luck with the stress test offsite.
Take care and appreciate your hard work! 🌟

@onetrickwolf onetrickwolf merged commit a08416f into ProvableHQ:testnet3 Feb 9, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants