Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for templates in create-aleo-app #831

Merged
merged 15 commits into from
Feb 9, 2024

Conversation

WillXing
Copy link
Contributor

Motivation

The templates in create-aleo-app is great start point for builders.

This PR is to improve the experience and usability by following changes:

  • Update program string from concat(+) to string template to improve the readability
  • Utilize localProgramExecution to use arguments as expected. This can be easier for user to understand the intention and how aleo program executed in app

Test Plan

Currently no unit test in templates, could be next things to working on. Now test plan is running them locally.

@onetrickwolf onetrickwolf self-requested a review December 30, 2023 15:17
@onetrickwolf
Copy link
Collaborator

Thanks for catching these yeah this is much more readable and clearly we meant to do something with those arguments and forgot haha.

Will review these next week need to take some time and update some other areas of the SDK and test.

Currently no unit test in templates, could be next things to working on. Now test plan is running them locally.

We have some e2e's in the works for this if you have any suggestions or opinions let me know though! I think I want to avoiding including unit tests in the templates themselves just so they can be lighter weight for people trying to start fast. Probably will set it up as some top level folder in create-aleo-app

@WillXing
Copy link
Contributor Author

I think I want to avoiding including unit tests in the templates themselves just so they can be lighter weight for people trying to start fast.

fair point, standalone e2e sounds like a good fit which can test multiple projects regardless the tech stack. 👍

@WillXing
Copy link
Contributor Author

Hi @onetrickwolf , how's things going. Got any time to review/approve this?

@onetrickwolf
Copy link
Collaborator

Hey @WillXing yeah sorry we've been stress testing the network last two weeks: https://twitter.com/AleoHQ/status/1744816856978915557

Back to normal flow this Monday, hoping to churn through some reviews and general SDK improvements over the next two weeks, sorry for delay appreciate the contribution!

@onetrickwolf onetrickwolf merged commit a5cc47b into ProvableHQ:testnet3 Feb 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants