wrong swiftimterfaces

[vdharankar]

ℹ Please fill out this template when filing an issue.
All lines beginning with an ℹ symbol instruct you with what info we expect. You can delete those lines once you've filled in the info.

Per our *CONTRIBUTING guidelines, we use GitHub for
bugs and feature requests, not general support. Other issues should be opened on Stack Overflow with the tag alamofire.

Please remove this line and everything above it before submitting.

• I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?

ℹ Tried building XCFramework using xcodebuild command line tool , built target for iOS and iOS-Simulator . Got both frameworks and tested them with sample code . The using '-create-framework' flag tried constructing XCFramework using both framework files. Go the XCFramework too but on using it with test code it showed an error related to wrong swift interface for 'cleanup' function in 'UploadRequest' class.

Expected that the resultant XCFramework will work just the way normal frameworks are working

ℹ Expected that the resultant XCFramework will work just the way normal frameworks are working

What happened instead?

ℹ Instead an error an error related to wrong swift interface for 'cleanup' function in 'UploadRequest' class.

Alamofire Environment

Latest Github version
11.4
5.2
iOS Simulator
10.15

[vdharankar]

Here is the more info on stack overflow question https://stackoverflow.com/questions/61009771/method-does-not-override-any-method-from-its-superclass-alamofire?noredirect=1#comment107936416_61009771

[jshier]

@vdharankar Can you provide the commands used to produce the xcframework? The commands you posted on StackOverflow don't work, there's probably something missing for a clean environment.

[vdharankar]

Commands came from here Carthage/Carthage#2799

[vdharankar]

Also You need to set the Build Libraries for Distribution option to Yes in your framework's build settings, otherwise the swift compiler doesn't generate the neccessary .swiftinterface files which are the key to future compilers being able to load your old library.

[vdharankar]

Also You need to set the Build Libraries for Distribution option to Yes in your framework's build settings, otherwise the swift compiler doesn't generate the neccessary .swiftinterface files which are the key to future compilers being able to load your old library.

this setting is 'NO' in current build.

[jshier]

Yes, Alamofire doesn't support library distribution. If that's a requirement for XCFramework support, it will not work.

[vdharankar]

Commands came from here [Carthage/Carthage#2799](Carthage/Carthage#2799

Commands I have mentioned on Stackoverflow work my end

[vdharankar]

Yes, Alamofire doesn't support library distribution.

Can you explain that a bit ? do you mean old iOS style frameworks ? If yes I have created one and used it with a simple code and I found it working

[vdharankar]

Issue happens only after embedding these individual frameworks into XCFramework .

[jshier]

It is unsafe to manually enable library distribution for libraries which don't have it enabled, like Alamofire, as our APIs are not guaranteed to maintain binary stability, as defined by the limitations of library evolution mode. You particular issue is caused by the fact that we added an override to cleanup for UploadRequest in 5.0.5, which is apparently not a resilient change, and is one of the reasons Alamofire doesn't support library mode.

[jshier]

It appears that adding an override is supposed to be a resilient change, so I'm not sure what the issue is, but its certainly related to library evolution.