Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]audio_padding can set start time and end time independently #98

Open
echoIIImk2 opened this issue May 8, 2023 · 4 comments

Comments

@echoIIImk2
Copy link

I hope audio_padding can set start time and end time independently, just like subs2srs does. Because I found that in most subtitles, start is accurate, adding a 50ms is enough, while end is often not accurate, need to add 300ms or 400ms.

@tatsumoto-ren
Copy link
Member

Please read issue.md.

@tatsumoto-ren
Copy link
Member

in most subtitles, start is accurate, adding a 50ms is enough, while end is often not accurate, need to add 300ms or 400ms.

Can't you then set the timings manually? I imagine each subtitle is going to need different padding values.

@echoIIImk2
Copy link
Author

What I mean is that start and end need to be set with different padding in most cases, so it is better to set them separately.

@tatsumoto-ren
Copy link
Member

Yes, but how do you know ahead of time what padding you need to set? I think it's less error-prone to adjust the timings in mpv before making a card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants