Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service worker can't be registered. #937

Open
hv0905 opened this issue Nov 29, 2020 · 0 comments
Open

Service worker can't be registered. #937

hv0905 opened this issue Nov 29, 2020 · 0 comments
Assignees
@Anduin2017
Labels
Bug Confirmed The way to repro a bug have been found.

Comments

@hv0905
Copy link
Member

hv0905 commented Nov 29, 2020 •
edited

Environment

  • Environment: Staging(Pre-release)
  • Last git commit: aaaaaa
  • Platform: Web Desktop\Web Mobile\Electron\PWA\TWA
  • Browser: Chrome\Edge\Firefox\Safari\Others

How to repro

Service worker can't be registered.
image

Expected situation

I expect that...

Other information

  1. This is because navigator.serviceWorker.controller is null when sw isn't registered. But supportWebPush() will return false when it's null, which blocks the sw to be registered.
  2. It's improper to check supportWebPush when registering sw, since sw provides many other functions, such as caching.
@hv0905 hv0905 added Bug Confirmed The way to repro a bug have been found. labels Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anduin2017 Anduin2017

Labels
Bug Confirmed The way to repro a bug have been found.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Anduin2017 @hv0905