Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Zoomable video #300

Open
leporel opened this issue Aug 10, 2022 · 1 comment
Open

feature: Zoomable video #300

leporel opened this issue Aug 10, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@leporel
Copy link
Contributor

leporel commented Aug 10, 2022 •
edited

Add feature to control menu "Zoom" like in attached video.

zoom.mp4

I just add transform: scale(--value-zoom); to css file add simple control panel.
Maybe also settings in configuration AllowZoom: true also would be good.

I'm not good at JS so I can't create a good pool request, sorry.
@leporel leporel changed the title Zoomable video feature: Zoomable video Aug 10, 2022
@SangwonOh
Copy link
Member

@leporel Hi. Sorry for late response!!

This looks very good!

Please feel free to make a pull request. Once I merge your pull request, then I will refactor your code!
Be our contributor.
Thanks!

@SangwonOh SangwonOh added the good first issue Good for newcomers label Jan 12, 2024
@leporel leporel mentioned this issue Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leporel @SangwonOh