New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using Framebuffer::GFX and Adafruit's NeoMatrix Mapping for 2D support #3906
Comments
Cc @embedded-creations and I'll reference this on the FB leds are awesome discussion |
To add context, I would have contributed to WLED, but I wrote most of my code before WLED had enough to do what I needed (or actually barely existed), so I have WLED like support on esp32 and other chips, plus the full 2D matrix and API support, but it wasn't meant to be as easy to use by othres as WLED , so it makes more sense for WLED to continue to grow and expand with its user base, than for me to add the WLED bits missing to my code. the middle of that page shows the wifi support which is custom to my need, but can be adapted of course All that said, I still think most people will be better off using wled in the long term once equivalent 2D support can be added (by that I mean the APis I mentioned and neomatrix support) |
You are welcome to make a PR. The same requirements from #2420 are still valid and have to be respected though. FYI there are now about 190 effects that may need rewriting when changing low-level APIs. Most of these are not 2D. And BTW WLED's canvas is called The example from the picture above is fully possible with current automatic mapping built into WLED. |
Ok, I was given incorrect information when I asked/looked. If WLED already fully supports complex inter and intra zmapping of LED within and between LED matrices, equivalent to what Neomatrix and LEDMatrix offer, then adding support for FastLED::NeoMatrix isn't as useful. |
I can't re-open #2197 but in the last 3 years since I opened it, I've heard of more peole using wled and now trying to do 2D with it, which it wasn't originally built to do.
as discussed on https://www.facebook.com/groups/LEDSAREAWESOME/posts/2360328277495951/?comment_id=2362375507291228&reply_comment_id=2363141040548008¬if_id=1713103541286836¬if_t=group_comment_mention
I pointed out that adafruit's mapping work is both super important and useful when you chain matrices as getting coordinate right, is non trivial:
Maybe it would be a good time to re-visit looking at
and especially
top easily add 2D framebuffer support that will work with all kinds of hardware, support the weird Z mappings of chained panels, and allow using code that uses FastLED, Adafruit::GFX, and LEDMatrix primitives and APIs. All this stuff is already written and already exists, might as well re-use it :)
The text was updated successfully, but these errors were encountered: