Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story 5 Task 3 #39 #63

Merged
merged 13 commits into from Mar 5, 2023
Merged

Story 5 Task 3 #39 #63

merged 13 commits into from Mar 5, 2023

Conversation

vs2961
Copy link
Contributor

@vs2961 vs2961 commented Mar 1, 2023

No description provided.

@vs2961 vs2961 changed the title Story 5 task 3 Story 5 Task 3 #39 Mar 1, 2023
Copy link
Owner

@Ai-Albert Ai-Albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're no longer using AddActivity and Coordinate, can we remove those dead files?

@vs2961
Copy link
Contributor Author

vs2961 commented Mar 2, 2023

I wanted to leave them in for reference, but if you're confident that we don't need them I could delete them

@vs2961 vs2961 requested a review from Ai-Albert March 2, 2023 04:15
@Ai-Albert
Copy link
Owner

I think we can delete them, cuz we can always checkout main and look at what we had for MS1 to look back at for reference. That way we can keep our MS2 stuff cleaner.

@vs2961 vs2961 merged commit 090fd70 into dev Mar 5, 2023
@vs2961 vs2961 deleted the story_5_task_3 branch March 5, 2023 01:54
@Ai-Albert Ai-Albert linked an issue Mar 17, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Story 5 - Task 3 - Store Name and UID in Database
2 participants