Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No component factory found for NgxMaterialTimepickerContentComponent #219

Closed
steven274 opened this issue Sep 19, 2019 · 18 comments
Closed

Comments

@steven274
Copy link

Error when using with angular 8

Screen Shot 2019-09-19 at 17 27 03

@danielwojcik
Copy link

same here after upgrade from 4.0.2

@Astrofyziky
Copy link

Same here, with Angular 8 using timepicker version 5.1.1

image

I get a module not found error when adding NgxMaterialTimepickerContentComponent to entryComponents:
image

Code in HTML:
image

@Agranom
Copy link
Owner

Agranom commented Sep 19, 2019

Try to use v5.1.0 till I fix that

@kevinjh07
Copy link

Same error with NgxMaterialTimepickerContentComponent here, Angular 8.
No problem using v5.0.0.

@Agranom
Copy link
Owner

Agranom commented Sep 19, 2019

Check please is there ngx-material-timepicker-content.component.d.ts in your node_modules path:
ngx-material-timepicker/src/app/material-timepicker/components/ngx-material-timepicker-content.component ?

@Astrofyziky
Copy link

Yes, that file does exist within that folder. This is with version 5.1.1, and 5.1.0 (which gives me the same error as 5.1.1).

image

@Agranom
Copy link
Owner

Agranom commented Sep 20, 2019

could you provide an example ? Because I cannot reproduce it

@Agranom
Copy link
Owner

Agranom commented Sep 20, 2019

And try to remove and install again

@Astrofyziky
Copy link

I was able to figure it. In my particular case it had to do with lazy loading. It's not enough to add it to the imports of the components module, it also has to be added to the routing module

image

@tuoitrexuquang
Copy link

tuoitrexuquang commented Sep 26, 2019

@Astrofyziky i got same issues with "ngx-material-timepicker": "5.1.1", "@angular/core": "8.0.0" version when imports of the components module. but it's work when added to the routing module. maybe we have issue witt lazy loading

@Agranom
Copy link
Owner

Agranom commented Sep 26, 2019

I guess it's resolved. Otherwise it could be reopened.

@Agranom Agranom closed this as completed Sep 26, 2019
@julienboulay
Copy link

This issue is not resolved and should be reopened. Same as @tuoitrexuquang , I need to add NgxMaterialTimepickerModule to the root module of my app.
This import in the root module should not be required and we should be able to import the module in a lazy module of the app.

@Agranom Agranom reopened this Oct 9, 2019
@w0jcik
Copy link

w0jcik commented Oct 9, 2019

same issue here - does not work in lazy module (ng8.2.9)

@Agranom
Copy link
Owner

Agranom commented Oct 9, 2019

Okey, I'll check it

@Agranom
Copy link
Owner

Agranom commented Oct 11, 2019

I've made some investigation and found out the similar issue on the angular repo.
angular/angular#14324
In short, Entry components follow the same rules as providers in lazy loaded modules and they are only visible inside lazy loaded module. So you need to import module into app.module

@Agranom Agranom closed this as completed Oct 11, 2019
@srukshan98
Copy link

Check this Solution!
Click Here

@samirthakare
Copy link

image

get same error while using time picker with angular8.

@Agranom
Copy link
Owner

Agranom commented May 30, 2020

@samirthakare import module into your AppModule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants