Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Table / Pagination to Astro #213

Open
roblevintennis opened this issue Apr 30, 2022 · 1 comment
Open

Port Table / Pagination to Astro #213

roblevintennis opened this issue Apr 30, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request high priority Items we want to tackle first

Comments

@roblevintennis
Copy link
Contributor

roblevintennis commented Apr 30, 2022

Must go on a next branch!

https://discord.com/channels/830184174198718474/961848242281259078/976275440379510854

Table and Pagination ported to Astro

Package is agnostic/astro and we'll need to add these components to that package.


Blocker:
We should do #191 to realize feature completeness first

I think we should actually wait on #167 and do the Astro port first since our deadline for submission is coming up next week and we can always tackle #167 after


How

We'll need to add these to:
https://github.com/AgnosticUI/agnosticui/tree/master/agnostic-astro/src/lib/components
e.g. Table.astro and Pagination.astro. We can glean a lot by looking at other examples. Probably Tabs and Menu are most complex and thus useful examples.

The test pages are here and can be adapted as these components are actually realized:
https://github.com/AgnosticUI/agnosticui/blob/master/agnostic-astro/src/pages/en-v1/table.astro
https://github.com/AgnosticUI/agnosticui/blob/master/agnostic-astro/src/pages/en-v1/pagination.astro

@roblevintennis
Copy link
Contributor Author

@Croug ☝️

@roblevintennis roblevintennis added enhancement New feature or request mvp required to launch mvp labels Apr 30, 2022
@roblevintennis roblevintennis added this to the MVP milestone Apr 30, 2022
@roblevintennis roblevintennis removed the mvp required to launch mvp label May 8, 2022
@roblevintennis roblevintennis added mvp required to launch mvp and removed mvp required to launch mvp labels May 17, 2022
@roblevintennis roblevintennis removed this from the MVP milestone May 18, 2022
@roblevintennis roblevintennis added the mvp required to launch mvp label Jan 16, 2023
@roblevintennis roblevintennis self-assigned this Jan 16, 2023
@roblevintennis roblevintennis added high priority Items we want to tackle first and removed mvp required to launch mvp labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority Items we want to tackle first
Projects
None yet
Development

No branches or pull requests

2 participants