Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte use of quotes and linting #189

Open
roblevintennis opened this issue Apr 18, 2022 · 3 comments
Open

Svelte use of quotes and linting #189

roblevintennis opened this issue Apr 18, 2022 · 3 comments
Assignees
@gcsecsey
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
MVP

Comments

@roblevintennis
Copy link
Contributor

roblevintennis commented Apr 18, 2022 •
edited

We should have a standard and be consistent within the agnostic-svelte/* package. I don't think any of our configurations is enforcing consistency there.

  • See what the consensus is in the Svelte community and follow
    UPDATE: Sounds like Croug found the answer:

it seems in the svelte docs they use ' for imports and ` for strings generally

  • Add a linter and formatter that can enforce and fix respectively
  • Backfill and commit fixes
@roblevintennis roblevintennis added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 18, 2022
@roblevintennis
Copy link
Contributor Author

@Croug per our conversation in Gitter ☝️

@Croug
Copy link
Collaborator

Croug commented Apr 18, 2022

Perfect

@roblevintennis roblevintennis added this to the MVP milestone May 7, 2022
@roblevintennis roblevintennis assigned gcsecsey and unassigned Croug May 15, 2022
@roblevintennis
Copy link
Contributor Author

I'm reassigning to @gcsecsey so @Croug can focus on getting the Table / Pagination stuff pulled through. We're getting close to completing the svelte typescript port and I think this should be added to it before we nuke the old agnostic-svelte package and replace it with what's now agnostic-svelte-ts/*

@roblevintennis roblevintennis added the mvp required to launch mvp label May 17, 2022
@roblevintennis roblevintennis removed the mvp required to launch mvp label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcsecsey gcsecsey

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
AgnosticUI MVP
Status: Todo
Milestone
MVP
Development

No branches or pull requests
3 participants
@roblevintennis @Croug @gcsecsey